Code Reviews: Honesty, Kindness, Inspiration: Pick Three
summary
Argues code review succeeds when it becomes a structured conversation not a blame game and introduces the Liz Lerman Critical Response framework with four steps and three roles Creator Responder Facilitator The creator states what mattered then asks questions responders ask neutral context questions and give opinions only with consent Process favors synchronous conversation over passive PR pileups and recommends steering reviews by designating creator asks first so feedback is targeted actionable and inspiring rather than nitpicky or adversarial
AI-written summary · about
chapters (18)
- 0:00Intro
- 0:11Honesty, Kindness and Inspiration: Pick Three
- 3:11Nit picking session How to name variables, how to organize files, clever one liners...
- 4:57Marathon Let's go over every line and discuss ad
- 6:24Don't take it personally
- 9:24Other code review anti-patterns
- 9:50The bottle neck
- 10:23Reviewer doesn't have enough context
- 11:07Reviewer too close to project
- 12:06Too asynchronous
- 13:17Required for every commit
- 14:08No one believes in the process
- 17:47The roles 1. The creator(s) 2. The responder(s) 3. Facilitator
- 18:29Statements of Meaning What about the work had meaning or stood out? Not evaluative.
- 19:39Questions From the Creator(s) Responders may give their opinion about things explicitly asked about.
- 21:10Neutral Questions from Responder(s) Purpose: to understand the context of the work. Should not have an embedded opinion.
- 22:49Opinions Responders may give their opinions on the work with the consent of the creator(s).
- 25:31This framework seems rigid. Does it have to be?
related talks
09mThe Art of Giving and Receiving Code Reviews Gracefully
20mConducting Humane Code Reviews
30mCode Reviews Using Art Critique Principles
29mCreating a Code Review Culture
46mCode Review: We Didn't Come Here to Suffer!
01h 01mBetter Code Reviews FTW!
46mCode Review, you said?
30mCode Reviews Using Art Critique Principles