Code Review Etiquettes 101
summary
Code review guidance that aims for measurable change: cite a 2017 GitHub study showing women’s PR acceptance 78.7% vs men’s 74.6% but only when women are not identifiable, recommend use questions not commands for every comment, link to documentation or Stack Overflow for evidence, document offline conversations in the PR, prefer small PRs and a PR template, allocate sprint time for reviews, decide a clear number of required approvals, and call out toxic comments early.
AI-written summary · about
chapters (25)
- 0:00Intro
- 1:27Why is etiquette important?
- 3:27Not an author review
- 5:41Questions vs commands
- 6:48Links to resources
- 7:36Explanations
- 8:15Review Scope Conscious
- 9:56Documenting offline conversations
- 11:17We vs You
- 12:26Review the card
- 13:56Calling out Suggestions
- 15:35Io. Taking the time to do it right
- 17:11II. Lump up similar suggestions
- 18:14No suggestion is too small
- 19:42Its a two way street
- 20:43Appreciate!
- 21:42Pull Request templates!
- 23:21Pre/Post PR tasks
- 24:45Finalizing the number of approvals
- 26:49Code reviews take time too
- 27:43Diffuse toxic behavior
- 29:09You are NOT your code
- 30:14Asking the right questions
- 30:51Comment on your review
- 32:20Self review
