~/talk

Effective Code Review

Talkat Android Summit 2019 · 2019-08-14..08-15· [developer-experience]
speakerdeck:tasomaniac
slides:none on file

Concrete rules and tools replace vague exhortations: require a short description and test plan on each PR, keep changes small and single‑purpose, prefer submit reviews in batch and use GitHub/GitLab features to reduce back‑and‑forth, rely on use IntelliJ commit dialog for formatting and changed‑file checks, add screenshots and labels, record follow‑up tickets for nonblocking work, summarize mixed comments and always include at least one praise, and write test plans for risky refactors.

AI-written summary · about

  1. 0:00Introduction
  2. 0:48What is Code Review
  3. 2:21Bag Example
  4. 4:38Blocking Comments
  5. 5:49Example
  6. 6:58Review When
  7. 9:15Review
  8. 9:48Questions
  9. 10:49Suggestions
  10. 12:18Examples
  11. 13:01Why
  12. 14:24Alternatives
  13. 17:01End of Review
  14. 19:42Comments
  15. 21:04Emojis
  16. 22:29Retrospective
  17. 23:20Criticism
  18. 24:29Examples of Criticism
  19. 26:13Questions Answers
  20. 27:44Pull Request
  21. 29:08Documentation
  22. 33:14Productivity
  23. 33:58Keeping small
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.