~/lightning

An Effective Code Review

Lightningat React Conf 2018 · on Friday, 2018-10-26· [developer-experience]
slides:none on file

Concrete rules: use suggestive wording and give readable phrasing examples like it might be more readable if we change this to use a temporary variable, focus reviews on design and readability not tiny style nits, treat everything as our code, comment even if unsure, and never rubber-stamp changes. Commit the same attention to every PR, prioritize collaborative, encouraging language, and gate dirty code so the repository stays maintainable.

AI-written summary · about

  1. 0:00Start
  2. 0:46Before I begin, let me tell you a story...
  3. 1:41Critique, don't criticize
  4. 4:35Never just rubber-stamp it!
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.