Async non-blocking code reviews

on YouTube ↗28m

" summary

Code reviews slow delivery when comments pile up: analysis of a few hundred PRs via the GitHub API shows PRs with 20–40 "root" rude comments take roughly 400–700 median hours to close and each blocking comment over 10 costs about ~10 median hours to resolve. Practical fixes include running PHP CS, PHPStan and Infection plus Behat scenarios locally via Makefiles and Docker, tagging specialists or using git-based reviewer heuristics, and marking comments as blocking or non-blocking so teams can disagree and commit and keep reviews async and non-blocking.

AI-written summary · about

" chapters (27)

1. 0:00Scribes
2. 2:18Introduction
3. 3:33Rewards
4. 5:06Time
5. 5:55Median Time
6. 6:45Comments take time
7. 7:06Small PRs
8. 8:04More reviewers
9. 8:40Rebasing
10. 9:16Why
11. 9:53PRs
12. 10:22Reward vs Conflict
13. 13:25Localisation
14. 14:08Communicating upfront
15. 15:02Nonblocking
16. 15:30De disagree and commit
17. 16:37Finding the right reviewers
18. 17:27GetKills
19. 17:52Suggestions
20. 18:51Etiquette
21. 19:10Looking at broader issues
22. 19:59Blast radius
23. 20:21Robustness
24. 21:02Code reviews
25. 21:34retrospective causality
26. 22:48final words
27. 23:32QA

" related talks

• 23mAsync non-blocking code reviewsFrank Koornstra · phpDay 2019
• 27mAsync non-blocking Code ReviewsFrank Koornstra · International PHP Conference Spring 2019
• 01h 02mEffective Code ReviewDave Liddament · PHP UK Conference 2023
• 56mAsync Code Reviews Are Choking Your ThroughputDragan Stepanović · Build Stuff 2023
• 57mAsync Code Reviews Are Choking Your Company’s ThroughputDragan Stepanović · FlowCon France 2024
• 47mGoldilocks and the Three Code ReviewsVaidehi Joshi · Red Dot Ruby Conference 2017
• 44mEffective Code ReviewDave Liddament · phpDay 2018
• 38mHow to Optimize Non-Coding TimeYishai Beeri · Voxxed Days Bucharest 2022