~/talk

Effective Code Review

Talkat phpDay 2018 · 2018-05-11..05-12· [developer-experience]
slides:none on file

Code review cuts long‑term costs by catching mostly evolvability bugs (traditional bugs are only ~20% of defects) and by improving team knowledge; studies in the talk say new features take ~28% longer and bug fixes ~36% longer in low‑evolvability code. The stack used includes automated tests, static checks like PHP CS Fixer, CI (Travis/Jenkins/Circle) and repo rules in Github (protect master, require up‑to‑date branches). Keep reviews small (≤400 lines, ≤1 hour), link commits to tickets, and the Github workflow is set up under 5 mins.

AI-written summary · about

  1. 0:00Introduction
  2. 3:50We all make mistakes
  3. 5:05Agenda
  4. 7:00Why Code Review
  5. 9:45Evolvability
  6. 10:35Security
  7. 12:43Spreading knowledge
  8. 13:17Bus factor
  9. 14:35Mentoring
  10. 15:53Being watched
  11. 17:33Automation
  12. 19:20Tests
  13. 20:52Have they covered everything
  14. 22:24When I understand this code
  15. 26:29Project conventions
  16. 28:00Questions of uses
  17. 30:46Technical vetting
  18. 36:13What makes a good commit
  19. 36:49What I dont like
  20. 38:31Comments
  21. 39:38Code View Tips
  22. 42:21Summary
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.