Async non-blocking Code Reviews

on YouTube ↗27m

" summary

Claim: PR comment volume and review practice drive huge delays; analysis via the GitHub API shows PRs with 20–40 root comments take ~400–700 hours median to close and going over ten root comments costs about 10 hours per root comment. Review effort spikes when PRs touch many files (30–40 files → ~2 minutes per file). Remedies are concrete: use hack, PHP CS, PHP infection, rebasing, Makefiles and docker to run checks locally, tag specialists, split big design discussions out of PRs, and prefer targeted reviewers.

AI-written summary · about

" chapters (21)

1. 0:00Intro
2. 0:34Scribes
3. 2:32Introduction
4. 4:08Reward
5. 5:41Time
6. 7:57Quality
7. 10:09Cognitive load
8. 11:15Time hits on morale
9. 12:19Reward vs conflict
10. 13:58Offloading
11. 15:33Run locally
12. 16:46Communicate upfront
13. 19:09Tag your specialists
14. 20:11Get Kills
15. 20:46Blocking Comments
16. 21:28Etiquette
17. 22:23Blast Radius
18. 22:41Robustness
19. 23:35Code Reviews
20. 24:14Kenefick Framework
21. 25:36Final Words

" related talks

• 23mAsync non-blocking code reviewsFrank Koornstra · phpDay 2019
• 28mAsync non-blocking code reviewsFrank Koornstra · Dutch PHP Conference 2019
• 57mAsync Code Reviews Are Choking Your Company’s ThroughputDragan Stepanović · FlowCon France 2024
• 56mAsync Code Reviews Are Choking Your ThroughputDragan Stepanović · Build Stuff 2023
• 47mGoldilocks and the Three Code ReviewsVaidehi Joshi · Red Dot Ruby Conference 2017
• 06m50 Haunting Shades of PR Dark MatterElad Kohavi · DevOpsDays Tel Aviv 2024
• 38mHow to Optimize Non-Coding TimeYishai Beeri · Voxxed Days Bucharest 2022
• 29mBreaking the PR Review BottleneckPavel Oborin · PyCon AU 2026