~/talk

Async non-blocking code reviews

Talkat phpDay 2019 · 2019-05-10..05-11· [developer-experience, devops-and-delivery]
slides:none on file

Claim: code review delay is quantifiable and avoidable — GitHub API logs show a PR with 20–40 root comments takes ~400–700 median hours to close and each root comment costs ~10 median hours. Concrete fixes: run linters and style fixes locally with php‑cs and PHPStan, enforce with Makefiles and Docker, use mutation tests for coverage, tag domain experts and use git blame to find reviewers, prefer small PRs (avoid 30–40 files) and apply disagree and commit for low‑impact objections.

AI-written summary · about

  1. 0:00Intro
  2. 3:30Rewards
  3. 5:53Root comments
  4. 6:45ELISA quality
  5. 8:34Cognitive load
  6. 10:37Reward vs conflict
  7. 12:19Offloading
  8. 13:51Pairing
  9. 14:46Nonblocking
  10. 16:05Reviewers
  11. 17:04Git
  12. 17:31Commenting
  13. 18:45Team
  14. 19:17Blast Radius
  15. 19:44Robustness
  16. 20:59Complex Quadrant
  17. 22:04Last Words
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.