Getting the most out of code review
summary
Practical checklist for improving reviews: specific automation (use Google Java Format via Gradle, import a shared Android Studio style, run CI on Jenkins/Travis/Circle to ensure builds and tests pass), concrete static tools (Android Lint, custom rules), social protocols (label PRs, use “nitpick” for trivial issues, split huge changes — avoid > 2,000 lines), review early/often, start high-level then drill down, give example fixes (Kotlin immutable-map replacement) and aim for incremental “letter‑grade” improvements.
AI-written summary · about
chapters (15)
- 0:00Start
- 0:04Code Review
- 1:26Sounds pretty easy?
- 2:54What can we do to get rid of that anxiety?
- 4:07Code format
- 11:13Requests, not commands!
- 12:29Review Early, Review Often
- 16:14High level, then down
- 18:00Code examples
- 19:56Limit response on repeated issues
- 22:51Bring up a letter grade
- 24:31Split up large changes
- 26:20Respect scope of review
- 30:52Handle stalemates
- 31:52Merci!
related talks
39mEffective Code Review
40mCode Review - How to Do It Better?
41mCracking the Code Review from Guesswork to Automated Guidance
45mHow to get the most out of code reviews
18mHow To Review Someone's Code While Not Being A Jerk!
01h 05mGetting Good (or Better) at Code Reviews
38mCracking the Code Review: from Guesswork to Automated Guidance
45mCracking the Code Review