Effective Pull Request Reviews
summary
Advice focuses on concrete habits: keep PRs small and broken into commits, include code plus tests and documentation, and write a description with explicit how to test steps and images for UI. Reviewers read ticket first, ask many questions, and run diffs in the same review UI. Leave contextual comments, link references, and use triple‑slash for docs versus double‑slash for why notes. Treat PRs like public artifacts, avoid dismissive phrasing, and always point out the good things.
AI-written summary · about
chapters (33)
- 0:00Intro
- 0:18iOS Conf SG
- 1:47Communication & Collaboration
- 2:16Effective Pull Request Reviews
- 2:28Developer Playground
- 3:00(Unique?) Teamwork
- 3:40From "Your" Code to "Our" Code
- 4:33Shared Responsibility
- 6:23It Goes Both Ways
- 6:56Keep it to the Point
- 8:32Code. Tests. Documentation.
- 9:45Explain Your Thought Process
- 10:12How can this be Tested?
- 11:13Visualise
- 11:36Assume Best Intentions
- 12:10Manage Expectations
- 13:09Soak Up Knowledge
- 13:57Read the Ticket and Description
- 14:46Ask Questions
- 14:59Ask More Questions
- 16:10Self-Review
- 17:10Re-Read a Review
- 17:58Share Knowledge
- 18:26Provide Context
- 19:30Provide References
- 22:54Non-Code Pull Request Reviews
- 24:06In-Person Review Review Over a Video Call
- 25:21Git is Forever
- 25:47Your Pull Request Environment May Not Be
- 26:46Avoid Derogatory Words
- 28:01The most important thing: Interesting work with good people - Aaron Hillegass
- 29:01Point Out the Good Things
- 29:47Thank you! @basthomas
related talks
38mPull Requests and Reviews for Good
29mThe Art of Humanizing Pull Requests (PR’s)
22mContinuous Improvements of The Code Review Process
21mA Guide to Perfecting Pull Requests
21mContinuous Improvements of The Code Review Process
29mThe art of humanizing Pull Requests (PR’s)
28mPull Requests: Merging good practices into your project
39mEffective Code Review