~/talk

A Guide to Perfecting Pull Requests

Talkat EmberConf 2022 · on Tuesday, 2022-04-19· [developer-experience, soft-skills]
slides:none on file

Advice focuses on concrete rules and tools: avoid a 1300‑line PR, prefer splitting work and making one PR per version, and keep reviews under 200 to 400 lines based on a Cisco study. Use clear commit subjects and bodies, adopt conventional commits, rebase or squash to make linear history, add screenshots or record walkthroughs with QuickTime, and annotate commits. Use GitHub/GitLab resolve‑comment features and open follow‑up tickets for out‑of‑scope suggestions so merges happen only after every comment is addressed.

AI-written summary · about

  1. 0:00Intro
  2. 0:14A GUIDE TO PERFECTING PULL REQUESTS
  3. 4:17ORGANIZING YOUR COMMITS
  4. 5:50THE SIZE OF OUR STORY
  5. 7:47HOW TO BREAK DOWN PULL REQUESTS
  6. 8:44OUR STORY'S INTRODUCTION
  7. 9:54THE PR DESCRIPTION
  8. 13:07ADDING VISUALS
  9. 15:13BECOME YOUR OWN REVIEWER
  10. 18:54ADDRESS ALL COMMENTS
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.