Pull Requests: Merging good practices into your project
summary
A survey of 682 developers finds code reviews cut the work spent fixing bugs to the point that teams otherwise spend 45% of their time on technical debt, so the talk gives concrete practices: pull request templates, GitHub status checks + CI, git flow and small branches, linters and pre-commit hooks, review apps and deploy previews, and a minimum-approval rule (Atlassian recommends assigning 1.5× reviewers). Concrete examples include a horrific 71 files PR and advice to reserve daily time to keep the review queue empty.
AI-written summary · about
chapters (28)
- 0:00Intro
- 1:17About Luca
- 2:15Why review code
- 3:18Change in development process
- 3:45Code review
- 4:12iOS calculator
- 4:28Code reviews
- 6:00Best practices
- 6:12Pull request templates
- 6:54Status checks
- 8:18Git flow
- 9:35Branches are cheap
- 9:53PR size
- 11:00Kitchen sink analogy
- 12:41Write clear commit messages
- 13:09Positive and negative feedback
- 14:41Working with poor requests
- 16:10Not a linter
- 16:27Minimum approvals
- 18:20Screenshots
- 19:04Observations
- 20:09Big Tips
- 21:38Insights
- 22:22Realworld examples
- 23:23Teaching not just telling
- 23:58Guidelines
- 24:51Checklist
- 25:37Senior Developer Review
related talks
11mPull Requests: Merge With Your Team
28mPull My Code: Effective Code Review
38mPull Requests and Reviews for Good
21mA Guide to Perfecting Pull Requests
17mGitHub Pull Requests for Everyone
57mA Meritocracy of Pull Requests
22mContinuous Improvements of The Code Review Process
16mAn unpopular opinion: Get rid of Pull Requests!