What I Learned about Code Review Teaching 8th Grade Poetry

on YouTube ↗34m

" summary

Argues that democratizing review — get juniors to review and rotate ownership — speeds learning and reduces bugs: code review catches defects but only ~30% of comments are useful unless reviewers repeatedly see a file (usefulness density rises from ~30% to ~70% after ~5 reviews). Uses GitHub pull requests and version control; parallels come from teaching poetry with peer feedback groups (one poem every practice becomes four–five attempts) and a PaymentSpring case where after ~5 weeks peer review shows no drop in quality and fewer escaped defects.

AI-written summary · about

" chapters (34)

1. 0:00PLATINUM SPONSORS
2. 0:39GOLD SPONSOR
3. 1:11ELIXIR CHAMPION SPONSORS
4. 1:34AUSTIN, TEXAS 2020 LONESTAR ELIXIR
5. 4:33Transference
6. 5:05Virtues of
7. 5:58The Old Ways
8. 6:51Low throughput . Lots of idle time • Long feedback loop • Lost context
9. 9:41The New Ways
10. 14:07Research
11. 15:19Feedback v. Evaluation
12. 15:47Likelihood of acting on feedback (Dylan William)
13. 16:33Formal Code Review (Fagan, 1976)
14. 17:06Modern Code Review
15. 17:26Ad Hoc Code Review
16. 17:39Explicit Goal: Catch defects
17. 18:45Implicit Goal: Maintain an accurate mental model
18. 19:33Implicit Goal: Share knowledge & power
19. 20:14Obstacles
20. 21:40Case Study: Payment Spring
21. 23:40Was it a happy accident?
22. 24:15The biggest predictor of usefulness density is how many times a reviewer has reviewed this file already.
23. 25:44People with habits usually continue those habits
24. 26:14The only way to improve is to practice
25. 27:10Core Thesis
26. 28:19Code review ensures mental model accuracy
27. 29:17Takeaways
28. 29:28Use version control.
29. 30:01Practice compassion and seek understanding
30. 30:45Establish shared language and expectations
31. 31:40Ask for code reviews, especially from junior developers.
32. 32:22Most changes need only one or two reviewers.
33. 32:52When possible, leave fewer comments
34. 33:31Audit your code reviews

" related talks

• 52mTeaching through Code ReviewDerek Binkley · Developers Summit 2021
• 30mCode Reviews Using Art Critique PrinciplesStacy Morse · PyCon 2018
• 01h 22mKeynote: Growing Better ProgrammersGuy Davidson · ACCU 2022
• 25mCode Review of Senior Python EngineersKeith Yang · PyCon AU 2023
• 01h 01mReviewing Beginners' C++ CodePatrice Roy · CppCon 2022
• 22mLeveling up through Code ReviewsElisheba Anderson · NationJS React 2018
• 42mHow to Lead Open Source Projects and Teams with Better FeedbackJessica Tegner · Open Source Summit Europe 2023
• 44mSurviving Code ReviewsLorna Jane Mitchell · Codemotion Rome 2016