Our Fight Against Super Bad Patterns in Legacy Rails Apps

on YouTube ↗38m

" summary

Migrated three apps from Rails 2.3.5/Ruby 1.8.7 to Rails 4.2.1/Ruby 2.1 over about 11 months across three companies, kept production while refactoring and adding features. Replaced gems (file upload, pagination), moved assets to the asset pipeline, swapped Prototype to jQuery, removed attr_accessible for strong parameters, and wrote RSpec/Capybara specs after migration. Found and fixed four concrete anti‑patterns: too many layers (merged one‑to‑one models into rich ActiveRecord), dreamy methods (split and name methods), global hashes converted to value objects, and controllers split to avoid mass‑housing.

AI-written summary · about

" chapters (10)

1. 0:00Start
2. 5:35Ruby & Rails Migration (Upgrading)
3. 8:01Our Applications Kind of health check service B to B Handed over to our company from the other development company which originally developed the system
4. 20:54We love good patterns
5. 21:59Too many layers
6. 24:40Deamy method
7. 31:32This is the combination of 2 bad patterns
8. 31:51You need to chase the identifier not to harm other features
9. 32:14Dreamy method Write a different method for a different need Doubt adding an argument and "if" Extract common parts Use polymorphism Stop this pattern in early stage
10. 32:46Conclusion

" related talks

• 23mCrafting Rails CultureHiroshi Shibata · Rails Pacific 2014
• 36mWorking Compassionately with Legacy CodeAmar Shah · RubyConf 2015
• 39mThe Long Ball - Upgrading long lived Rails apps from 1.x-4.0Jesse Wolgamott · RailsConf 2013
• 22mRiding Rails for decadesRafael Mendonça França · RubyConf Colombia 2016
• 01h 05mLegacy Rails Q&AMichael Feathers, Adam Hawkins, Andrzej Krzywda · wroc_love.rb 2014
• 41mExploring the History of a 12-year-old Rails ApplicationNathan L Walls · RailsConf 2017
• 39mDown The Rabbit Hole: An Adventure in Legacy CodeLoren Crawford · RailsConf 2018
• 41mOff the Tracks - Challenging the Rails MindsetNick Sutterer · RubyConf AU 2013