~/talk

Goldilocks And The Three Code Reviews

Talkat JSConf Budapest 2017 · 2017-10-26..10-27· [developer-experience]
slides:none on file

Surveyed research ties three concrete review types to outcomes: inspections (30–60 minute checklists), short reviews (catching small changes and dropping error rates from 55% to 2% or correctness from 86% to 99.6%), and walkthroughs (learning more than defect-hunting). Industry survey yields average personal benefit ~8.6, most teams require one reviewer and keep reviews under an hour, and failure modes cluster around energy (rubber-stamp approvals, unequal attention) and substance (nitpicks vs. empathetic, actionable feedback). Practical fixes: commit hooks (Huskie), PR templates, linters, smaller PRs, designated reviewers, RFCs and iterative process changes.

AI-written summary · about

  1. 0:00Introduction
  2. 1:10Plot Summary
  3. 2:50Goldilocks
  4. 3:48Code Reviews
  5. 5:30Second Dev Job
  6. 6:23Small Team
  7. 7:10One day
  8. 7:55Panic attack
  9. 8:15What did you do
  10. 10:10Code Complete
  11. 11:05Ideal Code Review Process
  12. 12:10Team Code Review Process
  13. 12:25Collective Ownership Of Construction
  14. 13:15If Someone Leaves
  15. 13:40Defect Correction
  16. 14:05What are the different types of code reviews
  17. 14:20The history of code reviews
  18. 14:40What is a code review
  19. 15:20Inspections
  20. 15:45Short Reviews
  21. 17:20Walkthroughs
  22. 18:05Peerreview sophistication scale
  23. 19:00Goldilocks and the three code reviews
  24. 19:30Asking the internet
  25. 19:50Disclaimer
  26. 20:35Half Code Reviews Made You A Better Developer
  27. 21:15Most People Felt Code Reviews Were A Good Thing
  28. 21:40Most Engineering Teams Have Code Reviews
  29. 22:50Team Requirements
  30. 23:55Goldilocks Survey
  31. 24:45Energy
  32. 25:10Equal review
  33. 27:05Large commits
  34. 28:00Unequal reviews
  35. 28:30Survey results
  36. 29:50Negative reactions
  37. 30:35Negative experiences
  38. 31:05The disconnect
  39. 32:05Modernday Goldilocks
  40. 32:50Our Code Review Process
  41. 33:40What Ive Learned
  42. 34:05Commit Hooks
  43. 34:45PR Templates
  44. 35:35Screenshots
  45. 36:35Encapsulation
  46. 37:25Having specific reviewers
  47. 37:50Collective ownership
  48. 38:05Team culture
  49. 38:50Developing empathy
  50. 39:45Start a conversation
  51. 40:50I love code reviews
  52. 41:40Thank you
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.