Code reviewing like a champion
summary
Claims that code review catches most bugs citing 82 percent from Code Complete, and shows concrete practices: use commit-message context and pull-request templates, run checkstyle PMD FindBugs error-prone on pre-commit or CI, call backend owners for boundary changes, prefer questions like can you and replace you with we, and stop keyboard wars with the rule of three. Examples include Yelp’s mentorship and an iOS template that records alternatives and tradeoffs; measurable benefit is higher defect detection and faster review velocity when tools and norms are enforced.
AI-written summary · about
chapters (22)
- 0:00Intro
- 0:14Code Reviewing Like A Champion Jonathan Maltz - maltz
- 2:11Why Do Code Review • Basic Code Review Outline • How to Give Code Review Feedback
- 2:41Why do Code Review?
- 3:47Share Knowledge
- 4:23Build Context
- 4:41You understand the goal of the change You understand what is out of scope • You understand any high-level decisions
- 7:58Protip: pre-filled templates
- 8:49Evaluate Closer
- 10:15Take a Step Back
- 10:31Could this be done easier/better/faster?
- 11:01How to Give Feedback
- 11:43Feedback that makes people feel worse
- 13:11Start With Facts
- 13:55FAIL
- 14:25Static methods are bad. They cannot be mocked in normal JUnit tests.
- 15:01Link to External Resources
- 15:23Invite a Discussion
- 16:14Replace "You" with "We" or "Us"
- 17:17Rule of Three
- 17:37On a scale of 1-10 I care about this at about a 5. What about you? What are your major concerns?
- 19:16Celebrate the Good Stuff
related talks
41mCracking the Code Review from Guesswork to Automated Guidance
43mCracking the Code Review: from Guesswork to Automated Guidance
48mEffective Code Reviews
45mCracking the Code Review
38mImplementing a Strong Code-Review Culture
40mCode Review - How to Do It Better?
53mCode Review Beyond Code Style
45mCracking the Code Review